jwhitley/requirejs-rails

logical_asset_filter

merqlove opened this issue · 4 comments

Seems that this implementation is wrong for now:

config.requirejs.logical_asset_filter += [/\.hamlbars/]

Unknown + method.

Yes, seems that for now it is: logical_path_patterns

@merqlove Sorry about that; didn't think that users would externally modify that value. Are you cool with using logical_path_patterns? What does the rest of the Rails codebase say about naming conventions?

@carsomyr Yes, it works fine for me 👍 I use some custom template engines, like handlebars/hamlbars.
Speech above is about: logical_asset_filter unavailable from 2-3 latest releases ago. logical_path_patterns works fine => README 💯

@merqlove Alright, but if you can think of Rails naming conventions with regards to other, similar kinds of config values, let me know.