onChange not being triggered for CheckboxGroup and SwitchGroup

harsilspatel opened this issue 4 years ago · 3 comments

harsilspatel commented 4 years ago

To Reproduce
Playroom links for SwitchGroup and CheckboxGroup.

jxom commented 4 years ago

Hmm, yeah, seems like it doesn't get invoked for an uncontrolled group... However it does if you make it controlled (add a value prop)
https://bumbag.style/playroom/#?code=N4Igxg9gJgpiBcIA8BhAFjMBrARhAHgOIBOEArgA4A6AdgAR00CGAtjALxUgDuMTALhmJdaDCBX4BLCDQDO7YAG1RDOsDoAbJjhgb4dAOQBlMjRoBPAwBo6ANyYayMfQdmmLBugF8rKhuq0dPUMAdUkaKEsbe0dnQ25wyM8fPzVNbV0XAHlbGGIwJll%2BazsHJxcIXPzC4u8VAF0vFRl0JhoAcw5gAAoASjp2AD46SDkIDRgAOg0Idu6uFrQ2zq5epvpS2IVXd0t1gHpBkC8gA

🎉1

jxom commented 4 years ago

Do you need the onChange handler for an uncontrolled input group?

harsilspatel commented 4 years ago

Thanks for the prompt reply! No worries, I'll have them as controlled input.

And since we're talking, do you mind fixing this to SelectMenu?: SelectMenuThemeConfig;?