Validate use of `Ref` ticket references

Question

Validate use of `Ref` ticket references

Closed this issue 8 years ago · 8 comments

The jQuery ticket reference guidelines allow the use of Ref to reference a ticket without closing it. These should be validated as well, since it will impact the efficacy of #33.

I used #33 there instead of gh-33 on purpose. 😈

jzaefferer commented 10 years ago

👍

arschmitz commented 8 years ago

👍

Answer 1 · 2015-01-22T21:58:57.000Z

Sounds reasonable. I'm currently heavily focused on finishing jQuery UI 1.12. Maybe someone from the Core team can help this and #33? Add a test, implement it in lib/validate.js. I can find a few minutes for reviewing PRs, tagging and publishing, but the implementation would have to wait a while.

Answer 2 · 2015-01-22T21:59:46.000Z

I created this ticket because I was looking at it, just didn't want to assign it to myself in case I got sidetracked.

Answer 3 · 2015-12-03T14:42:34.000Z

I actually disagree with this you don't always want to just ref a ticket what if you want to reference a blog post or some other reason for the change i think ref still makes sense in this case.

You can also use this to reference issues from other currently unsupported issue trackers like Jira

Answer 4 · 2015-12-04T04:56:57.000Z

I'd be fine with all these using the ticketPrefixes @jzaefferer proposed in #33 and one of the prefixes could be http to allow arbitrary links. Would that work for you @arschmitz?

Answer 5 · 2015-12-04T12:58:02.000Z

@dmethvin that would work for me sounds good

Answer 6 · 2016-07-04T13:15:55.000Z

I've reviewed this with @all3fox. We can't think of any usecase where commitplease could correctly point out an issue with a Ref line. If someone wants to include Ref undisclosed security bug CVE123, we should let them. Since this line isn't used to close tickets or generate changelogs, it seems like there's nothing to win here.

We can reopen with good usecases.