k-takata/the_silver_searcher-win32

64bit support?

jungle-boogie opened this issue · 3 comments

jungle-boogie commented

Hi All,

I have a file that's nearly 4GB, but I can't search through it:

> ag 10008488 master.tx
ERR: File master.tx failed to load: The parameter is incorrect.

I'm using ag-2019-02-17_2.2.0-11-g4f7aca7-x64.zip from
https://github.com/k-takata/the_silver_searcher-win32/releases

Is this because 4GB files won't work with ag?

k-takata commented

https://github.com/ggreer/the_silver_searcher/blob/4f7aca7b01c157866f5b708341bbccad0d7a6256/src/search.c#L317-L334
It seems that the code doesn't support a larger file than 4 GB, but I'm not sure about nearly 4 GB.

jungle-boogie commented

Thanks for the reply, @k-takata.

Do you think the ag output above is because of the file size? The file is simply a text file, which it parses just fine when it's not so large, i.e. same file at 1GB has no problem.

k-takata commented

Do you think the ag output above is because of the file size?

Yes, but it's not sure which API failed: CreateFileMapping or MapViewOfFile.