CasinoRoulette issues

[ferencdg]

I think there are 2 smaller problems with this contract:

1. it seems you allow 38 different numbers, but a roulette only has 37 numbers:
   

   ethereum-games/contracts/Gambling.sol

   Line 114 in 3128272

   require(choice >= -1 && choice <= 36);

2. you don't have any checks on the type of the bet here:
   

   ethereum-games/contracts/Gambling.sol

   Line 113 in 3128272

   else

however you do check the type here:

ethereum-games/contracts/Gambling.sol

Line 133 in 3128272

else if (bet.betType == BetType.Number) {

this can cause bets accidentally submitted invalid BetTypes like 3 or 4 to be permanently stuck

Anyway, it was a great book overal, thank you!