k3ng/k3ng_cw_keyer

potentiometer_enable_pin definition missing in some hardware configurations

Closed this issue · 6 comments

I kept getting a compile error when working on a Nanokeyer Rev. D.
The line - #define potentiometer_enable_pin 0 - is missing from several of the keyer_pin_settings_xxxx.h files.

No. I meant what I said. The line beginning with #define potentiometer_enable_pin is missing in both of the Nanokeyer hardware pin setting configurations. I have corrected it in my local copy, but don't know how to have it updated in the repository so that others don't have to track it down.

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

As was I. My point is, the code should have that corrected so that every person that comes along with a Nanokeyer doesn't have to track it down.

I was able to fix this issue by adding the #define statement but see also issue #69 with the NanoKeyer rev D.

As was I. My point is, the code should have that corrected so that every person that comes along with a Nanokeyer doesn't have to track it down.

I agree, I was just commiserating with you.

k3ng commented

This will be fixed shortly, version 2019.05.29.01. Thanks and 73