ansible-galaxy

Question

ansible-galaxy

itwars opened this issue 4 years ago · 36 comments

Hi all,
Here is my proposal:

I will probably create a new branch to test the ansible-galaxy directory structure and reorganize the structure!

Are you ok with that way to do it?

Answer 1 · 2020-06-05T08:18:54.000Z

If you need any pointers, I was initially refactoring those roles with aim to put them in ansible-galaxy at k3s-io/k3s#1649, but don't have time right now to get back to that.

Those refactored roles are currently used by me in https://github.com/thaum-xyz/ankhmorpork/tree/master/ansible

Answer 2 · 2020-06-05T08:20:53.000Z

Ok I will dive into your code, then create a new branch, and after testing this branch will be perhaps merge to master :)

Answer 3 · 2020-06-07T15:52:19.000Z

@ebesson @jpraczyk @xanmanning @onedr0p are all working on similiar goals. What would be the proper way to form a consensus?

Answer 4 · 2020-06-09T15:32:12.000Z

Let's talk! @ebesson @jpraczyk @xanmanning @onedr0p @emansom
What about a slack? Just send me your email to my email and I will be please to make it!

vincent.rabah@gmail.com

and as my first proposal, I have create a new branch call ansible-galaxy (beware I've just push yml file as it, this branch doesn't work yet!)

Answer 5 · 2020-06-10T07:08:19.000Z

Emailed 😊

Answer 6 · 2020-06-10T15:40:20.000Z

I have create k3s-ansible.slack.com

Answer 7 · 2020-06-14T19:20:11.000Z

Emailed ;-)

Answer 8 · 2020-09-28T21:17:39.000Z

Any progress on this?

Answer 9 · 2020-09-29T21:30:19.000Z

Seems that the master changed too quickly and the changes for galaxy too slow - because IMHO this seems a re-structuring of that repository.

I could help doing that, but parallel changes in the master will get merge conflicts very quickly.

Answer 10 · 2020-10-01T12:43:16.000Z

My suggestion is that we take some time to refactor that - while the commits to master should have a break.

@itwars what do you think?

Answer 11 · 2020-10-01T14:06:02.000Z

Yes I agree, for this purpose I've create the branch ansible-galaxy

Answer 12 · 2020-10-01T15:41:18.000Z

Yes, but this branch was created - in April?

while the commits to master should have a break.

And we should merge the refactoring as soon as possible. Otherwise, this will be a neverending story or never get merged, as it happend already once in k3s-io/k3s#1649

So I would create a new branch for that. But: the break is very important, until the refactoring is in progress (!)

Edit: Maybe we could technically stop commting to master for some days while the refactoring is in progress? This would really help!

Answer 13 · 2020-10-01T15:56:17.000Z

Also, I would like to welcome @geerlingguy to help doing that, for he is a very experienced ansible-guy 👍

Answer 14 · 2020-10-01T16:25:30.000Z

Hi everyone, I would like to point out that there is another k3s galaxy role that is well maintained, already in ansible-galaxy and works wonderfully. It would be nice if these could merge into one here. Maybe the maintainer there, @xanmanning could comment.

Answer 15 · 2020-10-01T22:51:35.000Z

Sounds good, I will have a look at it.

In a comment above also #39 (comment) https://github.com/thaum-xyz/ankhmorpork/tree/master/ansible is mentioned.

Edit: @onedr0p What about your repository https://github.com/onedr0p/k8s-cluster-k3s-ubuntu-ansible ?

Answer 16 · 2020-10-01T23:03:55.000Z

@rdxmb my repo uses @xanmanning k3s role under the hood. It's an opinionated way to provision Ubuntu, k3s, CNIs and other things I wanted.

Answer 17 · 2020-10-02T08:16:11.000Z

Hi everyone, I would like to point out that there is another k3s galaxy role that is well maintained, already in ansible-galaxy and works wonderfully. It would be nice if these could merge into one here. Maybe the maintainer there, @xanmanning could comment.

Thanks for your kind words @onedr0p. I have been asked a number of times about working in this role rather than my own or even creating PRs to merge my code in.

Unfortunately I'm quite constrained by time at the moment with a lot going on personally and some health issues as well. I did join the Slack group kindly set up my @itwars however time constraints have made it difficult to put in any valuable contribution on my part.

My role was created as a way of me advancing my career, mostly to write better quality Ansible but to also learn about Kubernetes. I'm still extremely new to Kubernetes as I don't work with it daily. This is why I display the warning about use of my role in production.

There are also valid reasons I can see for people not wanting to pick my role given the direction I'm intending on taking. I picked k3s as a project because at the time I don't think anyone else had created a role. I started a day or two after general release so as to not get influenced by other people's existing code so I can build the quality of my own code. I have always welcomed PRs though as this helps me learn and I've had some fantastic contributions. As this is a method for me to train myself I'm actually looking to go into the direction of implementing more validation checks into my role, which is intended to tell the operator of the role that everything is configured as expected and any deviations can be identified. The next step after that is to start looking at security best practices, implementing and validating those in the role. To me these are a sign of quality, however this may not be everyone's "cup of tea" (pardon the British expression).

TL;DR I'm under a lot of time constraints and I'm still in the early phases of my Ansible and Kubernetes journey so I'm not confident I can deliver real value.

Answer 18 · 2020-10-02T10:12:54.000Z

Thanks, @xanmanning

As this is in the rancher-namespace, would somebody from rancher coordinate the refactoring-process, as I wrote above with pausing/blocking the commits to master or something like that?

@itwars As you created this project, could you do that?

Edit: I have had a look over https://github.com/PyratLabs/ansible-role-k3s . It seems to be a very powerful - and also a kind of complex project for me. I like the idea to have a simpler way within this repository. However, it would be interesting to listen to rancher and what they prefer for "their" repository.
Technically, the first step would be to create a new branch based on the actual master here.

Answer 19 · 2021-05-19T19:22:33.000Z

seems there is no interest in doing that. Actually, I do not have time and priority for that anymore.

Answer 20 · 2021-09-06T18:23:09.000Z

Are you folks open for related PRs?

Answer 21 · 2022-01-02T22:33:12.000Z

Anyone fancy taking over as maintainer of my Ansible role? I don't have a lot of time to maintain it any more 😞 .

https://galaxy.ansible.com/xanmanning/k3s (Currently ranked number 1 k3s role by downloads on Ansible Galaxy).

Sorry to hijack, but if there's future interest in putting an official k3s Ansible role into galaxy I've got a fair following already. 🤷

Answer 22 · 2022-01-03T04:09:32.000Z

@xanmanning , I will look into your project and let you know.

Answer 23 · 2022-01-03T23:56:30.000Z

@xanmanning I can take it. @jon-stumpf Do you want to pair on this?

Answer 24 · 2022-01-03T23:57:02.000Z

If make sense we could also merge anything into here.

Answer 25 · 2022-01-04T00:01:04.000Z

It would be a shame to see @xanmanning work left unmaintained, I vote we migrate his work here if any maintainer here is up for it.

Answer 26 · 2022-01-04T00:18:21.000Z

@xanmanning How would you like us to proceed?

Answer 27 · 2022-01-04T19:43:01.000Z

I'm probably not going to be much help in terms of direction as I'm really just looking for an out and wanted to offer the opportunity for the code to be maintained by a bigger community, be it the k3s team or the k8s@home folk. Otherwise I'm just going to have to abandon the project

Happy for any features you like to be picked out into this repo, or for ownership of my repo to be transferred and features from this repo merged in.

Probably depends on interest, workloads and appetite as to which route is taken and I'm keen to try and assist with the transition.

Answer 28 · 2022-01-04T19:55:02.000Z

@xanmanning I volunteer. ✋

I can start the process by both reviewing the existing PRs in your repo and selecting which features make sense to start PRing here until k3s-io folks are confident with the changes or with taking it as the official repo. Until there, I will be happy to keep everything updated in your namespace. o/

Feel free to contact me via ayrton at riseup.net or via GitHub issues/discussions.

Answer 29 · 2022-01-04T20:16:24.000Z

@xanmanning if all else fails you could make @ayr-ton and I co-maintainers of your current repo, that's if you don't mind us bugging you once a year if something should come up that needs your attention ;) It would be a shame to lose all your commit history, ansible galaxy downloads etc..

I am also worried about the current state of the issues and PRs on this repo not getting any love from the maintainers and I wish one of them would chime in with their thoughts so it's not a dead-end.

Answer 30 · 2022-01-04T20:37:15.000Z

@onedr0p count on me to help with the PRs revision effort o/
So, reviewing the current plan:

Give a burst on the waiting revisions so we could move forward with current fixes and implementations
Once we get a stable flow, start making PRs from there to here.

On my side, I will give preference to anything that improves the flow for contributors (CI for the playbook, etc) or existing playbook flows that don't break any contract or idempotency.

Answer 31 · 2022-01-04T20:41:19.000Z

Once we get a stable flow, start making PRs from there to here.

Honestly I feel we cannot make that decision until we get a maintainer of this repo on-board, without that your efforts might be for nothing.

I strongly feel the best course of action would be to have a @k3s-io team member fork @xanmanning ansible repo into a new repository (or for it to be transferred), deprecate this one and divvy out permissions to the new one. But all that takes coordination from maintainers if they want this to happen.

Answer 32 · 2022-01-05T03:25:57.000Z

@onedr0p and @ayr-ton, I have reviewed all of the issues and PRs for this repo. Many can be closed. I have three PRs open and received no response to an email that I sent early last month. It would be good to get a new repo open under k3s-io so we could start fresh.

Answer 33 · 2022-01-05T07:52:39.000Z

Hi folks,

When I've initiate this issue, it was just for a matter of being compliant with ansible galaxy pattern: when you

ansible-galaxy init dummy

It create a directories structure with empty yaml files:

dummy      ────────────┬───────── vars
                       │
                       ├───────── tests
                       │
                       ├───────── templates
                       │
                       ├───────── tasks
                       │
                       ├───────── meta
                       │
                       ├───────── handlers
                       │
                       ├───────── files
                       │
                       └───────── defaults

So we must spread existing yaml files to thoses directories. And voilà!

Answer 34 · 2022-01-05T18:22:39.000Z

@itwars Seems that the discussion evolved. We could keep discussing the ansible-galaxy scheme here and/or move the other discussions to new issues to keep this one focused.

Current threads:

Ansible Galaxy support for the current repo (the original issue)
https://galaxy.ansible.com/xanmanning/k3s maintainability as the most mature role we have for k3s instead of creating a new galaxy submission. If there are new topics/issues to discuss we can create an issue there.
Integrate the code from xanmanning/k3s here in small PRs (starting from the galaxy feature) or maintain a fork here as part of k3s-io repos officially (could be a new issue, but the decision is up to k3s-io/k3s-ansible core committers)

I'm comfortable with any directions. Is a matter of which opportunities both communities want to invest energy.

Answer 35 · 2022-01-08T16:57:47.000Z

@onedr0p and @ayr-ton, do you want to discuss a roadmap?

Answer 36 · 2022-06-26T02:18:57.000Z

Did this ever go anywhere? I see that https://github.com/PyratLabs/ansible-role-k3s still displays a help-wanted sign.