Set env variables have no effect when value is 0 or false

Question

Set env variables have no effect when value is 0 or false

ronny35 opened this issue 3 years ago · 6 comments

ronny35 commented 3 years ago

Details

Helm chart name and version:

k8s-at-home: 7.3.1

What steps did you take and what happened:

When I apply env.NODE_TLS_REJECT_UNAUTHORIZED = 0 (or false), environnement variable is not deployed

Relevant Helm values:

env:
NODE_TLS_REJECT_UNAUTHORIZED: 0

What did you expect to happen:

Must be present.

Answer 1 · 2021-04-29T16:18:54.000Z

Hi! Thanks for taking the time to raise this issue. The correct way to pass truthy (true/false/1/0, etc) environment variables in Helm charts is by quoting them.

I believe this snippet should work:

env:
  NODE_TLS_REJECT_UNAUTHORIZED: "0" # or "false"

Answer 2 · 2021-04-29T20:41:38.000Z

Hi @bjw-s,

I have the same error.

Answer 3 · 2021-05-03T07:35:51.000Z

@ronny35 What @bjw-s is trying to tell you:
Env-Vars should always be strings, so need quotes.

He is not saying he has the same error.

Answer 4 · 2021-05-03T07:49:12.000Z

I've added an explicit unit test (3fa4861) to verify that the quoted "0" works, and it works as expected

Answer 5 · 2021-05-05T17:48:23.000Z

@bjw-s Can also be closed afaik.

Answer 6 · 2021-05-06T05:28:46.000Z

I am closing this issue for now. If the problem still occurs for you, please don't hesitate to comment again.