k8snetworkplumbingwg/multi-networkpolicy

SharedInformerFactory missing a Shutdown method

trozet opened this issue · 2 comments

trozet commented

The Shutdown method is useful for waiting for the informer to be stopped when running unit tests:
kubernetes/code-generator@e4b7976

It is missing:
https://github.com/k8snetworkplumbingwg/multi-networkpolicy/blob/master/pkg/client/informers/externalversions/internalinterfaces/factory_interfaces.go#L34

I tried updating code-gen and regenerating, but it doesnt seem to work. Not sure why...

jcaamano commented

WE have a similar situation with the NAD factory

  • 👍1
tssurya commented

yeah hit this with the NAD factory today (I wonder if there is another issue for NAD or if we should open one...)