[BUG] Node Slice Fast IPAM Uses Incorrect Range Field When Specs Change
ivelichkovich opened this issue · 1 comments
ivelichkovich commented
Describe the bug
A clear and concise description of what the bug is.
https://github.com/k8snetworkplumbingwg/whereabouts/blob/master/pkg/node-controller/controller.go#L436 should use ipamConf.IPRanges[0].Range
instead of ipamConf.Range
like the if block above it that checks for the change to spec
Expected behavior
A clear and concise description of what you expected to happen.
Whereabouts node controller should handle spec changes
To Reproduce
Steps to reproduce the behavior:
- Create a NAD
- Change node_slice_size or ip_range
Environment:
- Whereabouts version : latest main
- Kubernetes version (use
kubectl version
): N/A - Network-attachment-definition: N/A
- Whereabouts configuration (on the host): N/A
- OS (e.g. from /etc/os-release): N/A
- Kernel (e.g.
uname -a
): N/A - Others: N/A
Additional info / context
Add any other information / context about the problem here.
ivelichkovich commented
Thanks @xagent003 for finding this, please help raise MR to fix 👍