k911/swoole-bundle

Unable to upgrade to v0.8.3 on PHP 8.0 due to assertion BC break

spyridonas opened this issue · 4 comments

spyridonas commented

Is your feature request related to a problem? Please describe.
Installation of this package does not work with php 8
(beberlei/assert[v3.0.0, ..., v3.2.7] require php ^7 -> your php version (8.0.1) does not satisfy that requirement.)

Describe the solution you'd like
Merge #417

k911 commented

For now you can use a workaround:

composer upgrade --ignore-platform-reqs

There is a known issue regarding assertion library beberlei/assert#309 because in 3.3.0 there is a strict requirement to install intl extension, which would have to be required then by swoole bundle and would have introduced BC break here.

I also think that if you would install the intl extension you should pick up the latest version without any workarounds.

spyridonas commented

Thanks for the reply, i will try using your suggestion.
After reading the beberlei/assert issue and searching around, there's a suggestion to use https://github.com/webmozart/assert instead.
Maybe that's the solution ? I don't know if you've consider/tested it before.

k911 commented

@spyridonas I'm satisfied with how the current assertion library works. It may be wise to actually remove this dependency completely and use exceptions and checks crafted directly for this bundle. However, it would take a significant amount of time to rewrite and properly test it, so I think it is probably easier to fix the assertion library instead, as PR beberlei/assert#310 exists which should handle that.

k911 commented

I'm closing this one as fix in dependency has been released