kainjow/Mustache

Lambda Renderer Incorrectly "grabs" Text Ahead of the Lambda Tag

hellochitty opened this issue · 6 comments

hellochitty commented

Take the following example:

 kainjow::mustache::mustache tmpl{
 "It is true that {{#wrapped}}{{name}} is awesome.{{/wrapped}}"};

 kainjow::mustache::data data;
 data["name"] = "Willy";
 data["wrapped"] = kainjow::mustache::lambda2{
 [](const std::string& text, const kainjow::mustache::renderer& render) {
    const auto renderedText = render(text);
    return "<b>" + renderedText + "</b>";
  }};

Here, we'd expect the output of rendering the template to be:
"It is true that <b>Willy is awesome.</b>"

Instead we get:
"<b>It is true that Willy is awesome.</b>"

What's also interesting is that the pre-lambda text is only rendered for the first time render is called within the lambda:

kainjow::mustache::data data;
data["name"] = "Willy";
data["wrapped"] = kainjow::mustache::lambda2{
  [](const std::string& text, const kainjow::mustache::renderer& render) {
   const auto& pre_lambda_text = render("");
    const auto& renderedText = render(text);
    return pre_lambda_text + "`<b>`" + renderedText + "`</b>`";
  }};

The above actually produces the output we desire, but the issue is that the lambda should not capture text outside of the wrapping tags.

kelson42 commented

I can confirm that bug

kainjow commented

Thanks! It does look related to the new line_buffer changes in version 4. I have an experimental fix, but will do some more testing.

kainjow commented

@hellochitty @kelson42 please test the change out and let me know if it works.

kelson42 commented

@kelson42 I confirm the problem is fixed. Thank you! Hopefully an official release soon :)

  • 👍2
kainjow commented

I just released v4.1.

  • 👍1
hellochitty commented
  • 👍1