causify-ai/kaizenflow

Unit tests limit_price_computer_using_volatility.py and limit_price_computer_using_spread.py

Closed this issue · 5 comments

samarth9008 commented

oms/limit_price_computer/limit_price_computer_using_spread.py

oms/limit_price_computer/limit_price_computer_using_volatility.py

In these two files, we have function calculate_limit_price()

We just want to extend the existing unit tests if an invalid side is supplied as the argument.

Take a look at the test file of this class to get a sense on how to proceed with the issue.

You do not need to test the whole functions, but just when the user supplies invalid side

See unit test doc to follow the code style
Also highly recommend to read this doc before submitting 1st PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

samarth9008 commented

@heanhsok Lets start with this simple issue for now

  • 👍1
dremdem commented

@heanhsok
Can you please assign an epic.

samarth9008 commented

@dremdem Kaizen-ai is for interns. they will not have access to zenhub.

  • 👍1
gpsaggese commented

Yes, let's only ping people on cmamp to assign Epic.
Mentors should be in charge of managing the project management part.

Do we need to update the EpicMeister docs?

heanhsok commented

Closing as PR is merged.