kami-blue/client

bug: CollectionSettings do not trigger a value listener

5HT2 opened this issue · 3 comments

5HT2 commented

Code example:

        visibleList.listeners.add {
            MessageSendHelper.sendRawChatMessage(visibleList.value.toString())
            mc.renderGlobal.loadRenderers()
        }     

This code is never triggered when calling visibleList.add(), or something similar.

You also cannot do visibleList.value = someNewList due to value being a val.

5HT2 commented

Here (

) is the gremlin responsible. It assumes you're always setting the value by doing setting.value = something, which clearly isn't the case for a Collection

5HT2 commented

Theoretically the valueListeners should also work for this as well, when this is fixed

5HT2 commented

A temporary workaround has been added to CollectionSetting by #2186, I don't know of a better way of doing it