kamilion/customizer

Remove all hardcoded strings

Opened this issue · 1 comments

Deleted user commented

This is another follow up from issue #121 regarding translatable 'About'.

Recalling from the top issue:

To begin with, the contents of Contributors and License (Short version of COPYING) are hardcoded into GUI file. These have been hardcoded since Gambas ports (see FAbout.form and commit cca469c) and even after GUI has been rewritten in Python (see commit 7fc37cc).

The affected files are gui.ui and tr/* files.

Removing all hardcoded strings is actually done before issue #125 that would bring back 'About' tab. Initially, I was imagining the opposite. Redesigning UI is better done from an empty tab widget.

In Qt 4 Designer, do the following.

  • Delete 'License' tab all together with hardcoded strings (Delete tab_5 from the sidebar);
  • Delete the child item QTextEdit in 'Credits' tab
  • Preserve "set on runtime!" QLabel because this is needed to display version;
  • Rename 'Credits' to 'empty' to indicate emptied tab widget for temporary (Later, this will be renamed to 'About' in the following issue)

Following this, there will be no more duplicate or hardcoded text within the source code and this will end the hardcoding nightmare that this project had been carrying over many years.

This shall be done first to prepare empty tab, before bringing back 'About' tab.

Deleted user commented

This issue has been fixed in last update for "old stable".