kamranahmedse/pennywise

Multiple windows and/or instances of a window

geigel opened this issue · 4 comments

geigel commented

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

This is not a request for popup windows or new window links to work. Rather, this is a request to add the feature of having multiple separate Pennywise windows open to allow for a few windows playing videos.

Expected behavior

Would be great to have a CMD+N or File > New Window ability where a new instance of the app allows for its own URL and configuration independent of other open pennywise windows. So I could have one video playing and another one too.

URL attempting to access

N/A since this is a feature request independent of URL

Screenshots (Optional But May Be Requested)

N/A

Pennywise Version:
0.6.3

OS / OS Version:

macOS 10.13.6 (17G5019)

Any issue that doesn't have all of these filled in will be closed, if yours is closed reopen with everything filled in.

skplunkerin commented

Yes please!

akash-joshi commented

Seems easy enough to make. I'll do this.

  • 👍1
akash-joshi commented

So an issue I'm facing while building this is that the menu items and shortcuts only affect the parent window, not the newly opened window. I'm not sure how to deal with this problem 🤔
@alxwrd @kamranahmedse

Edit: Seems to be a Mac only issue https://github.com/electron/electron/blob/v0.36.7/docs/api/browser-window.md#winsetmenumenu-linux-windows

  • 😕1
alxwrd commented

Is it not possible to just launch another instance of Pennywise?

  • 👍1