kapoorlakshya/screen-recorder

WindowTitles#fetch omits results if the application binary name does not match the application name.

kapoorlakshya opened this issue · 0 comments

Examples

calc.exe vs Calculator
chrome.exe vs SRWare Iron or iron

Fix is to remove this check:

# window_titles.rb:33
.select { |t| t.match?(/#{application}/i) } # Narrow down to given application

Drawback is that the returned list will now have Windows OLE related window names, such as OleMainThreadWndName and nsAppShell:EventWindow. This will require an update to the README to inform the users of this change in behavior.

Also, need to update the filtering on N/A and blank window titles. These are usually present when using Chrome which spawns a new process for each extension.

raw_list.map { |i| i.gsub(/^Window Title:( N\/A|\s+)?/) }.reject!(&:empty?)