callee of deserializeHeader() doesn't handle error
ralphtheninja opened this issue · 3 comments
ralphtheninja commented
deserializeHeader()
might return an Error
if json is borked, but this it not taken care of by the callee.
https://github.com/noffle/multifeed/blob/3d2e999454363d3e123504efee57188ec862bf91/index.js#L291-L303
https://github.com/noffle/multifeed/blob/3d2e999454363d3e123504efee57188ec862bf91/index.js#L211-L231
ralphtheninja commented
We could just return null
from deserializeHeader()
and the callee should bail unless header
is ok.
ralphtheninja commented
I'm guessing we assume that the header
contains both header.version
and header.keys
?
hackergrrl commented
fixed in 2.0.4