black lines should be colorable
japanoise opened this issue · 2 comments
japanoise commented
self explanatory. the cursor has a thin black line between the top and bottom square, and the tag bars have one at the top; the text areas have one on the left. this should either be colorable or follow the colors of the rest of the interface, because it really goes pete tong if you use a dark theme
japanoise commented
Dear past me/other people that want the same thing:
The cursor can be fixed by the following patch to plan9port:
diff --git a/src/libframe/frinit.c b/src/libframe/frinit.c
index 90931f25..5e97ceb7 100644
--- a/src/libframe/frinit.c
+++ b/src/libframe/frinit.c
@@ -52,7 +52,7 @@ frinittick(Frame *f)
/* background color */
draw(f->tick, f->tick->r, f->cols[BACK], nil, ZP);
/* vertical line */
- draw(f->tick, Rect(f->tickscale*(FRTICKW/2), 0, f->tickscale*(FRTICKW/2+1), ft->height), f->display->black, nil, ZP);
+ draw(f->tick, Rect(f->tickscale*(FRTICKW/2), 0, f->tickscale*(FRTICKW/2+1), ft->height), f->cols[TEXT], nil, ZP);
/* box on each end */
draw(f->tick, Rect(0, 0, f->tickscale*FRTICKW, f->tickscale*FRTICKW), f->cols[TEXT], nil, ZP);
draw(f->tick, Rect(0, ft->height-f->tickscale*FRTICKW, f->tickscale*FRTICKW, ft->height), f->cols[TEXT], nil, ZP);Or conceivably you could manually patch the cursor (called "tick" in plan 9 jargon) after frinit in text.c in acme2k.
As for the tag bar etc. that's fixed by patches in forks. For instance my fork: https://github.com/japanoise/acme2k
japanoise commented