karaoke-dev/karaoke

Refactor the code in the caret position algorithm test.

Opened this issue a year ago · 1 comments

andy840119 commented a year ago

createCaretPosition and createExpectedCaretPosition in every caret position algorithm test looks fucking weird.
Not really sure have the better coding style for it.

andy840119 commented a year ago

Very not sure.

Maybe should create something like TestCaseCaretPositionHelper
And implement those methods:

createCaretPosition(IEnumerable lyrics, int lyricIndex)
createCaretPosition(IEnumerable lyrics, int lyricIndex, object index)
createExpectedCaretPosition(IEnumerable lyrics, int? lyricIndex)
createExpectedCaretPosition(IEnumerable lyrics, int? lyricIndex, int? index)