karaoke-dev/karaoke

Change `xxxEditMode` to better naming

Closed this issue · 3 comments

andy840119 commented

EditMode is toooo generic.
image
Should change into other naming, like LanguageEditSection ?

andy840119 commented

maybe RomajiTagEditMode -> RomajiTagEditStep?
Because technically, the step to edit the romaji (or other property) is from left to right.

andy840119 commented

image
Man it's hard to make the decision 🤔

image
[Update]
Guess NoteEditStep is better.

andy840119 commented

Renamed.