karczews/RxBroadcastReceiver

Manifest merger fails with error.

Closed this issue · 5 comments

Hey. My app's manifest contains following lines:

  • android:allowBackup="false"
  • android:supportsRtl="false"

And it can't compile because of these issues:
image
image

Now I use tools:replace="android:allowBackup, android:supportsRtl" as a quick workaround but as I understand that's not the desired behavior.

Could you please fix?

ajoz commented

Hi,
Could you describe me the configuration of your project. Is it a single app project? Or maybe several library projects + the app. I have a vague idea how to fix the issue you are having but I would like to reproduce it first and create some testing playground for it.

Okay. Reproduction steps:
Create new project
Add this dependency implementation 'com.github.karczews:rx2-broadcast-receiver:1.0.4'
Add next entries to the manifest android:supportsRtl="false" android:allowBackup="false"
Start sync
Get the error

ajoz commented

Thank you. Like I said I have a vague idea how to solve it, but I didn't want to send changes blindly. I will take a look at this today and put all relevant information in the ticket.

ajoz commented

Hi,

I've checked your issue and it is already solved with our current 1.0.5-SNAPSHOT build, please use it instead. It has a corrected manifest and I couldn't reproduce the issue with the manifest merger with it.

To use it please add oss.sonatype.org repositories to your dependencies. For example in the top level project build.gradle:

allprojects {
    repositories {
        google()
        jcenter()
        maven {
            url "https://oss.sonatype.org/content/repositories/snapshots"
        }
    }
}

Then you can add to your app dependecies:

implementation 'com.github.karczews:rx2-broadcast-receiver:1.0.5-SNAPSHOT'

So for now please use 1.0.5-SNAPSHOT version, we will make a release to maven central in the comming week.

Good luck!

Awesome thank you!