karlhorky/gray

Shows color image ONLY on IE 10, 11

musa-pro opened this issue · 2 comments

musa-pro commented

I wonder why it doesn't work in IE10, 11 and throws following error

unable to get property 'join' of undefined or null reference
jquery.gray.min.js 3,1464

Btw, I'm using jquery 1.12.4
You can test it here http://bit.ly/2qJWPPl

karlhorky commented

Hi @appskitchen, this is most likely because you have a version of Modernizr on the page already but the required feature detects are not included in your Modernizr build.

In #72 I'm going to make the Developer Experience (DX) a bit better. I've documented what to do with an existing Modernizr build and next in that pull request I will also make gray throw an error when the required feature detects are not included.

Edit: Error handling done in af51457

  • 👍1
karlhorky commented

These two improvements have been deployed with v1.6.0:

  • document how to use library with existing Modernizr
  • throw error with Modernizr build that doesn't include necessary feature detects