karljj1/kdis

feat: Change from KDIS_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR

Closed this issue · 2 comments

carlocorradini commented

The value of KDIS_SOURCE_DIR is not set and can cause UB. Moreover it can cause strange inclue errors while using"auto-tools" like CPM.

From:

kdis/KDIS/CMakeLists.txt

Line 36 in 3cdfc0f

SET(BASE_DIR ${KDIS_SOURCE_DIR}/KDIS)

To:

SET(BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/KDIS)
karljj1 commented

It's been a long time since I touched this, ill have to look through it and see what its purpose was.
Im happy to take a PR to change it.

carlocorradini commented

I'll create a PR 🥳

  • ❤️1