karlstav/cava

Inconsistent Release tar balls

Closed this issue · 1 comments

Describe the bug

Your releases tar balls are not the same for source code...

https://github.com/karlstav/cava/releases/download/0.10.4/cava-0.10.4.tar.gz

https://github.com/karlstav/cava/archive/refs/tags/0.10.4.tar.gz

the latter contains CMakeList.txt but the further doesn't.. feels confusing,
causing issues in Gentoo where we pull the cava-${version} ball, but we need the CMakeList in order to build a support library used by waybar project.

diff -ru 1/cava-0.10.4 2/cava-0.10.4/
Only in 1/cava-0.10.4: .github
Only in 1/cava-0.10.4: .gitignore
Only in 1/cava-0.10.4: CAVACORE.md
Only in 1/cava-0.10.4: CMakeLists.txt
Only in 1/cava-0.10.4: CONTRIBUTING.md
Only in 2/cava-0.10.4/: Makefile.in
Only in 2/cava-0.10.4/: aclocal.m4
Only in 2/cava-0.10.4/: ar-lib
Only in 1/cava-0.10.4: autogen.sh
Only in 1/cava-0.10.4: cava_win
Only in 1/cava-0.10.4: cavacore_test.c
Only in 1/cava-0.10.4: cavandroid
Only in 2/cava-0.10.4/: compile
Only in 2/cava-0.10.4/: config.guess
Only in 2/cava-0.10.4/: config.sub
Only in 2/cava-0.10.4/: configure
Only in 2/cava-0.10.4/: depcomp
Only in 1/cava-0.10.4/example_files: cava.gif
Only in 1/cava-0.10.4/example_files: etc
Only in 1/cava-0.10.4/example_files: test_configs
Only in 1/cava-0.10.4/input: winscap.c
Only in 1/cava-0.10.4/input: winscap.h
Only in 2/cava-0.10.4/: install-sh
Only in 2/cava-0.10.4/: ltmain.sh
Only in 2/cava-0.10.4/: missing
Only in 1/cava-0.10.4: todo

thanks!

There not supposed to be the same. Files like configure is not supposed to be checked in the source at all. The release is made by and for automake so it does not make that much sense to pack the cmake file in there. But as I see that it is used in this way, I can add it to the list so it gets packed in the next release.