karma-runner/grunt-karma

Please remove grunt from peerDependencies from package.json

paladox opened this issue · 13 comments

paladox commented

Please fix peerDependencies since it is failing grunt 1.0.0

Update
"peerDependencies": {
"grunt": ">=0.4.x"
},

to

"peerDependencies": {
"grunt": ">=0.4.0"
},

@dignifiedquire or @vladikoff Please could you do it since I doint want to sign the cla.

vladikoff commented

@paladox this is already done, having the "grunt": ">=0.4.x", is good enough.

In your project you are using grunt-karma@0.12.1 that wants grunt@0.4.x which still had "grunt": "0.4.x"

paladox commented

Thanks ive asked for this to be released as a 0.12.2 update.

paladox commented

@vladikoff Actually see gruntjs/grunt-contrib-watch@1f198f6

Still causing

19:34:58 npm ERR! peerinvalid The package grunt does not satisfy its siblings' peerDependencies requirements!
19:34:58 npm ERR! peerinvalid Peer grunt-contrib-copy@0.8.2 wants grunt@>=0.4.0
19:34:58 npm ERR! peerinvalid Peer grunt-contrib-jshint@1.0.0 wants grunt@>=0.4.0
19:34:58 npm ERR! peerinvalid Peer grunt-karma@0.12.1 wants grunt@0.4.x
19:34:58

Now its one module less since updating watch which had peer but removed it in 1.x update.

vladikoff commented

@paladox Yeah you can both remove and keep it. Some developers prefer to keep this setting.

paladox commented

@vladikoff do you suggest to keep it, how would we support 1.0 of grunt.

paladox commented

Please

vladikoff commented

@vladikoff do you suggest to keep it, how would we support 1.0 of grunt.

Plugins that will have >=0.4.0 as a peerDep will just work:

image

(rc1 is currently failing but that's npm's fault)

paladox commented

@vladikoff Oh ok thanks. So its grunt that the problem. Should we file a task with them.

paladox commented

Ive reported it here gruntjs/grunt#1488

dignifiedquire commented

New version released which should fix this

paladox commented

Thanks.