karolsluszniak/ex_check

mix check || mix check is dangerous

Closed this issue · 2 comments

dvic commented

If you have a compilation error in one of the tests, then the following will produce an exit code 0: mix check || mix check.

More info about this issue: https://angelika.me/2024/01/08/do-not-run-mix-test-failed/

TLDR: the exit code of mix test should be checked before running the retry

dvic commented

@karolsluszniak can we include the exit code in the manifest? or is this considered as a breaking change?

dvic commented

Update: in the next release of Elixir this won't be a problem anymore: it got fixed here: elixir-lang/elixir@99be673