Update style to the new 0.5 look
Closed this issue · 6 comments
We've started some work porting to the 0.5 look in the leaflet-0.5 branch of our fork.
https://github.com/UWMadisonUcomm/Leaflet.zoomslider
Let me know if it looks interesting. I've added some of the upstream changes to the js Control. There are two alternate versions of an 0.5 look; examples/test-05.html and test-05-alt.html. I wasn't sure if you would want to also maintain the 0.4 look either in the main project, or as a separate branch, so I created new stylesheets for now. I have L.Control.Zoomslider writing the +/- into the innerHTML of the buttons, as is done upstream in 0.5 now, which may be a challenge for both sets of styles to use the same control object without js options being set.
This also includes disabling of the zoom in/out buttons when the limit is reached, from issue #15.
It definitely looks interesting! Nice work!
I think making a 0.4 branch and then merging your work into master makes most sense. So if you drop all 0.4-specific code I'd be more than happy to merge a PR!
Also we need to decide on the UI. Not sure which I think is the best, maybe we should just ask on twitter?
EDIT: the close was just a misclick :D
Great, thanks. I'll work up a pull request. Getting some feedback on the UI from Twitter is a great idea.
Cool thanks!
I created a quick github page showing the two style variants from pull request #21 here.
http://uwmadisonucomm.github.com/Leaflet.zoomslider/slider-styles.html
I initially thought I liked the bottom one better, but most people in my office like the top one better :).
The pages are in the gh-pages branch of our fork https://github.com/UWMadisonUcomm/Leaflet.zoomslider. It could possibly be a rough beginning to issue #18.
Thanks, this is a great project!
Closing this now since i merged your changes! Thanks again!