kartik-v/strength-meter

Scoring penalty removed for successive lowercase letters

bobyonekenobi opened this issue · 1 comments

bobyonekenobi commented

Thank you for this plugin.

I just updated it from v1.0.0 to last (v1.1.4) on a very old app and noticed a change in the scoring behavior.
Point deduction does not apply anymore for consecutive lowercase letters presence.
It does apply correctly with consecutive uppercase letters though.

If I'm not mistaken, this change appeared in v.1.1.1 (because of the "break;" in the for loop of the getScore function).

To reproduce, compare before and after v1.1.1 :

  • install version before v1.1.1

  • type in "aaaaaa"

  • see calculated score : 1%

  • install latest version

  • type in "aaaaaa"

  • see calculated score : 28%

You can as well see this behaviour on the plugin demo page (http://plugins.krajee.com/strength-meter/demo).

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.