kasperisager/vanilla-bootstrap

Some things are broken?

Closed this issue · 9 comments

Vanilla: 2.1.8p2.
Bootstrap: 2.4.0

Did the full install with nodejs, bower, npm etc. Worked without errors.

When I install I use the default Bootstrap theme and these problems are apparent:

  • Sign In button freezes the page. Requires refresh.
  • Delete a post does not work (same as above, freezes page)

Anyone else seeing these problems?

Sounds like you have a JS conflict with another plugin. First step in debugging the issue would be checking your browser console for errors.

Hi!

Same to me... maybe a problem with jQuery 1.7.2? That's what my Vanilla uses!

If I change to 1.11.1, login works fine, but many other things are broken...

Thank you!

My comment above still applies; you'll need to check your browser console for errors.

I can confirm that things are broken with 2.4.0 and vanilla 2.1.8p2. My width on the front page is now 10.000px . Investigating that right now.
I also got jquery error about version mismatch (vanilla wants 1.9.2) so i replaced custom.js with 2014 version (from july?). And no more jquery error in browser console.

I can confirm there is 10000px width in every .css.

:~/Desktop/vanilla-bootstrap-2.4.0$ grep -roP ".{0,30}width:10000" .
./design/custom_darkly.css:Meta,.BlockColumn .BlockTitle{width:10000
./design/custom_yeti.css:Meta,.BlockColumn .BlockTitle{width:10000
./design/custom_flatly.css:Meta,.BlockColumn .BlockTitle{width:10000

and so on. Hope this is useful info and that i'm not spamming :)

I'm investigating. Could you open up a new issue? The width bug is not JS related.

Found the cause of the JS issue: A check was added in Bootstrap 3.3 to ensure that jQuery 1.9.1 and above is used (twbs/bootstrap#14852). Since Vanilla 2.1 still uses jQuery 1.7.2 this check will fail and JS execution will choke.

Since none of the Bootstrap JS components are used I'll simply remove them which should solve the issue.

Let me know if it works now!

Thanks allot, now it works! You´re awesome :)