kasperisager/vanilla-bootstrap

Navbar Collapse does not work

iStefo opened this issue · 6 comments

iStefo commented

Hi, thanks for this great theme!

Unfortuntely, I noticed that the navbar's collapse toggle doesn't work in compact layout. There is just nothing happening.

Also, $.fn.collapse is undefined (which probably is the immediate reason for this problem), but I am wondering why this is happening? Files were simply loaded from http://vanillaforums.org/addon/bootstrap-theme and then added to /themes.

EDIT: This happens to version 2.5.0, will try with 2.4.0 to see if this is a regression.
UPDATE: 2.4.0 fails with "Bootstrap requires jQuery version 1.9.0 or higher". Am I doing something wrong?

kasperisager commented

Man, Bootstrap 3.3 really did some damage 😦 The JS components were removed from the theme in 2.5.0 as the jQuery requirement was causing issues. Check out the release page for more info: https://github.com/kasperisager/vanilla-bootstrap/releases

I'd recommend loading the JS components of a previous release of Bootstrap (3.2 and below) as a workaround if you're using the theme as your mobile template as well.

joseamirandavelez commented

Ok I guess I have to download Bootstrap 3.2 copy the js file somewhere to the server and load it. But where should I put this script call? What file?

kasperisager commented

Simply loading the file is sufficient.

joseamirandavelez commented

I know, but in what file should I put the script tag? Sorry to bother but I
really don't know...
On Jan 29, 2015 11:29 AM, "Kasper Isager" notifications@github.com wrote:

Simply loading the file is sufficient.

—
Reply to this email directly or view it on GitHub
#145 (comment)
.

kasperisager commented

Ah, that would be default.master.tpl. No worries!

joseamirandavelez commented

Thanks man!
On Jan 29, 2015 11:37 AM, "Kasper Isager" notifications@github.com wrote:

Ah, that would be default.master.tpl. No worries!

—
Reply to this email directly or view it on GitHub
#145 (comment)
.