kata-containers/agent

CI lint issues because golangci-lint is updated to v1.16.0

Closed this issue · 3 comments

teawater commented 
/home/travis/gopath/src/github.com/kata-containers/agent
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/types
/home/travis/gopath/src/github.com/kata-containers/agent/pkg/uevent
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/client
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/grpc
/home/travis/gopath/src/github.com/kata-containers/agent/protocols/mockserver
grpc_test.go:872:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_CPU, 100, 120},
		^
grpc_test.go:873:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_FSIZE, 100, 120},
		^
grpc_test.go:874:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runc/libcontainer/configs.Rlimit` composite literal uses unkeyed fields (govet)
		{unix.RLIMIT_DATA, 100, 120},
		^
grpc_test.go:891:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_CPU", 100, 120},
		^
grpc_test.go:892:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_FSIZE", 100, 120},
		^
grpc_test.go:893:3: composites: `github.com/kata-containers/agent/vendor/github.com/opencontainers/runtime-spec/specs-go.POSIXRlimit` composite literal uses unkeyed fields (govet)
		{"RLIMIT_DATA", 100, 120},
		^
The command ".ci/static-checks.sh" failed and exited with 1 during .
Your build has been stopped.
bergwolf commented

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

teawater commented

Maybe we should create a docker image containing all the golang static checkers so that their versions are managed by ourselves.

We have version control for golangci-lint in test now.
https://github.com/kata-containers/tests/blob/0c8be9468395da61ec4ea672bdc003be8a10a350/versions.yaml#L55