Incorrect url
Semigradsky opened this issue · 10 comments
See https://github.com/kAworu/octostrap3/blob/ecfe5415d21a376d63c4141d643ba25d53439ac0/source/_includes/asides/github.html#L19 I feel like {{ root_url }} does not work. Works fine on line 25 and 32 though. Any idea ?
In source code:
jxhr.src = '{{ root_url}}/javascripts/libs/jXHR.js';
In HTML source:
jxhr.src = '/javascripts/libs/jXHR.js';
You miss a space before }}:)
https://github.com/kAworu/octostrap3/blob/a591e9a2c8f5e7e5c42edb56f5846e701580418a/source/_includes/custom/after_footer.html — "{{ root_url }}/javascripts/modernizr.js" replaced with "/octostrap3/javascripts/modernizr.js"
Did you test by adding the space ? I remember trying with the space and it did not work, but if it does now please feel free to fix it !
For example {{site.github_user}} does not use any spaces but it does work: https://github.com/kAworu/octostrap3/blob/ecfe5415d21a376d63c4141d643ba25d53439ac0/source/_includes/asides/github.html#L11
Also the "typo" is inherited from the classic theme (see https://github.com/imathis/octopress/blob/master/.themes/classic/source/_includes/asides/github.html#L15). Because last time I checked adding a space did not solve the issue, I left is as-is so to avoid a useless diff with the classic theme (from which we import changes sometimes).
In any way I tested this line isn't working:
jxhr.src = "{{ root_url }}/javascripts/libs/jXHR.js";
but few lines lower working fine:
<script src="{{ root_url }}/javascripts/github.js" type="text/javascript"> </script>
Could it be a bug in liquid ?
It seems more like a feature:) I think we could ask them. Later tomorrow I'll write an issue request to them.
Hi, @kaworu. Could you please take a look at issue on luquid project? We've got an answer.
Issue is two years old... and I don't see it by the URL mentioned now, seems fixed somewhere else. Resolving, if you don't mind.