Suboptimal ToLogStr instance for Lazy ByteString

Question

Suboptimal ToLogStr instance for Lazy ByteString

Closed this issue 5 years ago · 4 comments

The ToLogStr instance for lazy bytestring converts the lazy bytestring to a strict bytestring. This is unnecessary since Data.ByteString.Builder.lazyByteString pulls the chunks of a lazy bytestring straight into a builder.

Answer 1 · 2019-02-26T19:04:06.000Z

I believe this is fixed in the most recent version

Answer 2 · 2019-02-26T19:24:55.000Z

Nope, the instance still looks just like it does when I opened this issue:

instance ToLogStr BL.ByteString where
    toLogStr = toLogStr . S8.concat . BL.toChunks

Preferable would be:

instance ToLogStr BL.ByteString where
    toLogStr b = LogStr (fromIntegral (BL.length b)) (B.lazyByteString b)

Answer 3 · 2019-02-26T19:32:14.000Z

@andrewthad i looked at the wrong instance. so nevermind then

Answer 4 · 2019-03-04T01:54:25.000Z

@andrewthad Sorry, I didn't notice this. Could you send a PR?