kazu-yamamoto/logger

Build failure with base-4.5

Closed this issue · 3 comments

hvr commented

As can be seen below, fast-logger-2.4.17 fails to build with base-4.5 despite its metadata advertising compatibility with base >=4.5 && <5.

I've already performed a metadata revision to correct the metadata accordingly via https://hackage.haskell.org/package/fast-logger-2.4.17/revisions/

Please take this into account for future releases of fast-logger

3f0c54f0-52e2-348b-65cf-020133341ba6 [BuildFail]
Configuring library for fast-logger-2.4.17..
Preprocessing library for fast-logger-2.4.17..
Building library for fast-logger-2.4.17..
[1 of 9] Compiling System.Log.FastLogger.Imports ( System/Log/FastLogger/Imports.hs, /tmp/matrix-worker/1567653150/dist-newstyle/build/x86_64-linux/ghc-7.4.2/fast-logger-2.4.17/build/System/Log/FastLogger/Imports.o )
[2 of 9] Compiling System.Log.FastLogger.LogStr ( System/Log/FastLogger/LogStr.hs, /tmp/matrix-worker/1567653150/dist-newstyle/build/x86_64-linux/ghc-7.4.2/fast-logger-2.4.17/build/System/Log/FastLogger/LogStr.o )
[3 of 9] Compiling System.Log.FastLogger.IO ( System/Log/FastLogger/IO.hs, /tmp/matrix-worker/1567653150/dist-newstyle/build/x86_64-linux/ghc-7.4.2/fast-logger-2.4.17/build/System/Log/FastLogger/IO.o )
[4 of 9] Compiling System.Log.FastLogger.FileIO ( System/Log/FastLogger/FileIO.hs, /tmp/matrix-worker/1567653150/dist-newstyle/build/x86_64-linux/ghc-7.4.2/fast-logger-2.4.17/build/System/Log/FastLogger/FileIO.o )
[5 of 9] Compiling System.Log.FastLogger.Logger ( System/Log/FastLogger/Logger.hs, /tmp/matrix-worker/1567653150/dist-newstyle/build/x86_64-linux/ghc-7.4.2/fast-logger-2.4.17/build/System/Log/FastLogger/Logger.o )

System/Log/FastLogger/Logger.hs:45:13:
    Not in scope: atomicModifyIORef'
    Perhaps you meant `atomicModifyIORef' (imported from System.Log.FastLogger.Imports)

System/Log/FastLogger/Logger.hs:58:15:
    Not in scope: atomicModifyIORef'
    Perhaps you meant `atomicModifyIORef' (imported from System.Log.FastLogger.Imports)
<<ghc: 899510880 bytes, 1639 GCs, 23987419/79055408 avg/max bytes residency (8 samples), 180M in use, 0.00 INIT (0.00 elapsed), 0.46 MUT (0.52 elapsed), 0.60 GC (0.60 elapsed) :ghc>>
kazu-yamamoto commented

I changed it to >= 4.7.
Thanks.

hvr commented

@kazu-yamamoto Note that base-4.6 (i.e. the version bundled with GHC 7.6) appears to be compatible as can be seen at https://matrix.hackage.haskell.org/#/package/fast-logger -- but if you intend to advertise support for only GHC 7.8/base-4.7 and up via that, that's fine too! :-)

kazu-yamamoto commented

Yes but I don't want to support GHC 7.6 anymore!