kazurayam/unittest-helper

TestOutputOrgaizerner.Builder.subDirPath(Class) method --- this name is not good; it does not tell what it is

kazurayam opened this issue · 2 comments

For example, v0.3.3 supports the following code

public class SampleTest {

    private static final TestOutputOrganizer too = 
        new TestOutputOrganizer.Builder(SampleTest.class)
            .subDirPath(SampleTest.class).build();

    @BeforeAll
    public static void beforeAll() {
        too.cleanClassOutputDirectory();
    }
    
    @Test
    public void test_write_into_the_custom_dir() throws Exception {
        Path p = too.getClassOutputDirectory().resolve("sample3.txt");
        Files.writeString(p, "Hello, world!");
    }
}

I have a doubt about the method name .subDirPath().

It should rather be .subPathUnderOutputDirectory(Class), may be.

at v0.4.0-SNAPSHOT, the method was renamed:

previous:

    private final TestOutputOrganizer too =
            new TestOutputOrganizer.Builder(this.getClass())
                    .subDirPath(this.getClass()).build();

new:

    private final TestOutputOrganizer too =
            new TestOutputOrganizer.Builder(this.getClass())
                    .subPathUnderOutputDirectory(this.getClass()).build();

done at V0.4.0