unit tests shouldn't require docker

Question

unit tests shouldn't require docker

Closed this issue 6 years ago · 6 comments

There's many situations in which somebody may want to run mvn test without docker installed, currently a lot of the tests are wired up to use docker images for database etc, we should be able to use in-memory ones (H2 for postgres, etc ) and remove the hard requirement on docker for basic unit testing.

Answer 1 · 2019-01-15T14:24:13.000Z

TODO: Reminder to attribute @bsideup in the test container classes.

Answer 2 · 2019-01-15T14:25:27.000Z

@kbastani I appreciate it, but no need to ☺️

Answer 3 · 2019-01-15T14:32:55.000Z

What if people come asking questions!? :-)

Answer 4 · 2019-01-15T14:37:28.000Z

@kbastani figure it out! You are ~~the Architecture CTO~~ an engineer :D

Answer 5 · 2019-01-15T14:52:08.000Z

😝

…

On Tue, Jan 15, 2019 at 3:37 PM Sergei Egorov ***@***.***> wrote: @kbastani <https://github.com/kbastani> figure it out! You are the Architecture CTO an engineer :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB_6mi6n9DG6kdekDcFSl0U3yQl-hi6gks5vDeepgaJpZM4Z_5IF> .

Answer 6 · 2019-02-03T09:18:40.000Z

I am going to close this issue. The example project does require docker.