kbknapp/cargo-count

cpp is not the only extension for C++

ztdwu opened this issue · 7 comments

ztdwu commented 
{ ".cc", ".cpp", ".cp", ".cxx", ".c++", ".C" }

As far as I know, these are all valid extensions for C++ source code, with cc and cpp being the most popular. Currently cargo-count only supports cpp.

Vinatorul commented

Thank you for your contibution!
Yeah, there are more valid extensions for other languages, too, .htm for html, .h++, .h for c++ headers, etc.
It will be done when @kbknapp or I will have some free time 😉
I think I can try it tonight or tommorow.

kbknapp commented

@Vinatorul should be as easy as adding another line(s) below this one with the additional extensions.

edit: fixed link

ztdwu commented

I don't think the fix quite worked.

> touch a.cc
> touch a2.cc
> touch a3.cc
> ls
a.cc a2.cc a3.cc

> ~/workspace/cargo-count/target/release/cargo-count count 
Gathering information...
         Language  Files  Lines  Blanks  Comments  Code
         --------  -----  -----  ------  --------  ----
         C++       1      0      0       0         0
         C++       1      0      0       0         0
         C++       1      0      0       0         0
         --------  -----  -----  ------  --------  ----
Totals:            3      0      0       0         0
m-n commented

I think the multiple C++ printed lines is fixed on master, but hasn't been published to crates.io yet.

kbknapp commented

@m-n I apologise. I'm pushing some updates now, and I'll upload the new version to crates.io.

m-n commented

@kbknapp Thanks. I don't intend to rush you; I wanted to make sure the status of the issue was clear.

nabijaczleweli commented

This is fixed when you release current HEAD