Do not use CXX
Lecrapouille opened this issue · 5 comments
In
Simple-OpenGL-Image-Library/Makefile
Line 16 in 4fff135
and in Makefile:
Simple-OpenGL-Image-Library/Makefile
Line 42 in 4fff135
CXX is for g++ should be CC and CFLAGS and better to use ?=
This can conflict when doing make CXX=g++
That seems reasonable, do you have a reference of best practices I can refer to?
@kbranigan of course https://stackoverflow.com/questions/5541946/cflags-ccflags-cxxflags-what-exactly-do-these-variables-control the goal is to let you do stuff like make CC=clang CFLAGS=-Wdesired-options (in my case my main Makefile calls other Makefile (third parts) passing my CXX and CC and in our case we compile SOIL with g++ which ends badly :)
@kbranigan While not perfect, I adapt mine https://github.com/Lecrapouille/SOIL/blob/master/Makefile
Are you interested in doing a pull request? I'm up for incorporating your changes
@kbranigan here is the PR. Sorry for the long delay: I messed up myself I've already forked this project with different name but could not fork it again, so I used my organization name (but I should have used a branch) ... anyway.
The src/stb_image_aug.c is suffering of -Wmaybe-uninitialized and I'm not sure what if -soption is important (stripping) for a lib (a binary yes) and clang does not like it. I think -fPIC should be used by default for static libraries (this can be done in a second PR). Finally, https://github.com/SpartanJ/SOIL2 seems to be a fresher version to this repo, so I'm not sure if efforts has to be made for this current repo ?