The extension does not work for elements in iframes

Question

The extension does not work for elements in iframes

crdev opened this issue 11 years ago · 9 comments

crdev commented 11 years ago

An error message is displayed when an attempt to build a snippet for an element inside an iframe is made.

kenwarner commented 11 years ago

👍

Answer 1 · 2013-11-20T23:42:40.000Z

I decided not to hold the release any longer. This haven't made to v0.4, but I'll use it in v0.5.

Answer 2 · 2013-11-21T06:09:23.000Z

Did you encounter any issues with this patch?

Answer 3 · 2013-11-21T08:37:29.000Z

No, it's just I haven't reviewed nor tested it yet and since I'll be offline for the next 2 days I decided to deploy everything that was already finished.

Answer 4 · 2013-11-21T08:45:05.000Z

Sounds good. That patch is non-trivial, so might use some review/testing, indeed.

Answer 5 · 2014-03-21T19:33:47.000Z

Hey! Any progress on this? Or is the extension on hold for now?

Answer 6 · 2014-03-25T21:03:19.000Z

Hi Alexander, sorry that it took forever, I have no excuse for that.

Your code is pretty complicated and not directly related to the UI so I decided to move it from panel.js to a separate file: https://github.com/kdzwinel/SnappySnippet/blob/master/js/tools/InspectedContext.js . Let me know if you have any comments.

Tomorrow I'll also add the namespacing feature ( #19 ) and release the whole thing.

Thank you so much for all your help!

Answer 7 · 2014-03-26T00:00:14.000Z

Hey Konrad,

No problem at all here! I just stumped across SnappySnippet (was scanning through my old work materials) and decided to check back. Thanks for the update!

Answer 8 · 2014-03-26T17:07:56.000Z

Deployed with version 0.5 of the extension!