keen/keen-js

Support for IE 6/7

Closed this issue · 2 comments

vebinua commented

I'm running keen over IE7 and apparently this js error pop-ups on page load: http://screencast.com/t/PVI1foNTZm13, and references the keen.io library (https://d26b395fwzu5fz.cloudfront.net/3.2.6/keen.js)
"Error Message: Expected identifier, string or number"

*which points to the following line: http://screencast.com/t/o13Iw8PX (#3190, not minified)

There's a misplaced comma in that object definition which IE6/7, don't automatically fix.

**Fixing the above issue, leads to another one:
"JSON is undefined" error message. Here's a snapshot: http://screencast.com/t/HzaCgxp8sx

Since the library uses JSON.stringify function, it will need to include the JSON3 parser in order to support it on IE < 8.

I added reference to JSON3 (//cdnjs.cloudflare.com/ajax/libs/json3/3.3.2/json3.min.js) on top of the keen library.js and that fixes it.

Wish you could have this added/compiled, or if you could guide me how- That'll be really great!

dustinlarimer commented

Thanks for digging into this @vebinua! I've opened two issues to track each of these. I appreciate your help!

vebinua commented

You are very welcome @dustinlarimer! and Thank you too. Glad I could help!