keep-network/tbtc-website

Language Selector Issues

Closed this issue · 5 comments

  • improve quality of speech bubble shape

Screen Shot 2020-06-23 at 10 46 25

would an SVG work better? or different PNG export?
  • afford the ability to close dropdown when clicking off dropdown and choosing existing language selected.

Screen Shot 2020-06-23 at 10 46 31

documenting these for @ironng - lmk if there's anything i can do to help on this.

Thanks for flagging @Gluzman! The image is actually an svg already that I exported out of figma (and deleted the text from out of the middle):
https://github.com/keep-network/tbtc-website/blob/master/src/img/speech-bubble.svg
https://github.com/keep-network/tbtc-website/blob/master/src/img/speech-bubble-black.svg
Maybe you can help generate a better quality version? I don't know why the edge is not clean.

I can definitely add the ability to close the dropdown if you click outside of it too; I forgot about that detail!

@ironng i think i found the issue: i applied iOS corner smoothing in Figma, so now i have removed that and re-exported.

in the screenshot from the previous comment, there also appears to be an inversion of the outline of the bubble.

if it's helpful to know, the way it's built is:

  • unselected: - fill color inside with stroke 1px set to outside
  • selected - same stroke with fill color swapped to

new exports:
speech-bubbles.zip

@Gluzman Thank you for explaining and the new exports!

great, @ironng i'll unassign myself and let you take this one when you can.