keepkey/keepkey-firmware

Can't build KeepKey emulator (Ubuntu 18, GCC 7)

Closed this issue · 8 comments

gladcow commented

I've failed to build KeepKey emulator.

What I'm doing:

git clone https://github.com/keepkey/keepkey-firmware
cd keepkey-firmware
git submodule update --init --recursive
mkdir build
cd build
cmake -C ../cmake/caches/emulator.cmake ../ -DNANOPB_DIR=/path/to/nanopb-0.2.9.2 -DPROTOC_BINARY=/usr/bin/protoc
make

Simple cmake output (command cmake -C ../cmake/caches/emulator.cmake ../ -DNANOPB_DIR=home/sergey/src/nanopb-0.2.9.2 -DPROTOC_BINARY=/usr/bin/protoc >>cmake.out 2>&1): https://pastebin.com/TAkT3nNa

CMake output in trace-expand mode (command cmake --trace-expand -C ../cmake/caches/emulator.cmake ../ -DNANOPB_DIR=path/to/nanopb-0.2.9.2 -DPROTOC_BINARY=/usr/bin/protoc >>cmake.out 2>&1): https://www.sendspace.com/file/gmxtve (sorry, it is too big, can't place it at pastebin)

make output (command make >> make.out 2>&1): https://pastebin.com/CijBjZDw

I'm not sure, but looks like kkfirmware lib with unresolved references is linked before kkemulator lib that contains implementations.

keepkeyjon commented

Mind trying #135?

keepkeyjon commented

It won't fix all the warnings from the missing forward declarations, but it should help out at link time.

gladcow commented

Sorry to say, but it looks like it doesn't work, still linking errors.( Output is https://pastebin.com/kynzphWD

I'm still debugging it, I can add an additional info after I'll find an exact reason.

keepkeyjon commented

Looks like it never built strlcpy.c/strncpy.c. Maybe try blowing away your build directory & starting fresh? CMake caches a lot of stuff...

gladcow commented

Sorry, I have misinformed you at the beginning.( strlcpy.c and strlcat.c were not added to sources really, condition if(NOT ${KK_HAVE_STRLCAT}) doesn't work, may be because ${KK_HAVE_STRLCAT} is undefined if we haven't strlcpy, and so NOT ${KK_HAVE_STRLCAT} is not defined too.

I've tried

if(${KK_HAVE_STRLCPY})
else()
    set(sources ${sources} strlcpy.c)
endif()

if(${KK_HAVE_STRLCAT})
else()
    set(sources ${sources} strlcat.c)
endif()

and it is working correctly for me.

gladcow commented 
if(NOT DEFINED ${KK_HAVE_STRLCPY})
    set(sources ${sources} strlcpy.c)
endif()

if(NOT DEFINED ${KK_HAVE_STRLCAT})
    set(sources ${sources} strlcat.c)
endif()

is working for me too.

gladcow commented

Looks like it is CMake issue: https://gitlab.kitware.com/cmake/cmake/issues/19379
So, the correct way to check this variables is something like if(NOT KK_HAVE_STRLCPY) and if(NOT KK_HAVE_STRLCAT)

keepkeyjon commented

Oh wow, thanks for finding the root cause on that. Implemented in: e2b64e0

  • 👍1