keikoproj/active-monitor

Fix remedyWorkflow deleting RBAC and Service Account created from external system

awwwd opened this issue · 0 comments

awwwd commented

Describe the bug
active-monitor remedyworkflow is deleting RBAC configurations even if it was created manually or by any other external system and passed to the spec. There is existing code has re-use logic built in before creating any RBAC resouce so it's expected to retain those configurations also.

To Reproduce

  1. Create a service account with IRSA configurations
  2. Create a healthcheck and remedyworkflow that uses that service account to call AWS APIs
  3. When the remedy workflow triggers and completes it also deletes the service account.
  4. Once the IRSA configuration is gone the healthcheck no longer works as expected.

Expected behavior
It should retain the service account since it was created outside of the active monitor spec.

Screenshots
image
As you can see above the logs mentions that it's deleting service account and other RBAC configs.

Version: 0.9.0