kekland/equinox

Content scrolled under EqAppBar in Pixel 3XL Emulator

leodr opened this issue · 7 comments

leodr commented

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Screenshot_1563457835

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi!

Sorry, but I can't seem to find a bug or error in the image. Do you mean the empty space between the top of the screen and appbar?

Oh, I see it now, sorry.

I will test it and see where's the problem. Seems like something is wrong with EqLayout's handling of the status bar.

Should be fixed in v0.3.2, can you check that everything is working as expected?

leodr commented

Should be fixed in v0.3.2, can you check that everything is working as expected?

Well, the first bug is fixed, but it created another one ;)

In the main list there is space between the AppBar and the content.

Screenshot_1563556172

Dang it, strange that there are no issues on my galaxy s8 :/

Will fix tomorrow

leodr commented

Dang it, strange that there are no issues on my galaxy s8 :/

Will fix tomorrow

I think it has something to do with the Pixel 3 XL having that giant notch. You can always test in a Pixel 3 XL Android Emulator.

Oh, I found the issue. Yes, it was hard to see it on my Galaxy due to small status bar size, but the problem was in how ListView handles paddings. As written in the ListView:

By default, [ListView] will automatically pad the list's scrollable
extremities to avoid partial obstructions indicated by [MediaQuery]'s
padding. To avoid this behavior, override with a zero [padding] property.

So, that should be fixed in the QA app now in the latest commit.