kellyselden/ember-awesome-macros

ember-macro-helpers a required dependency?

Closed this issue · 11 comments

crhayes commented

I'm in the process of upgrading to Ember 2.13, and in doing so updating this library from 0.31.0 to 0.35.1.

My application was broken without explicitly running ember install ember-macro-helpers. Is this supposed to be a required dependency? If so, we should update the documentation to reflect this.

kellyselden commented

It's not required unless you have something like `import raw from 'ember-macro-helpers/raw';' in your app. What npm/yarn version are you on? What is your error message?

bartocc commented

+1

my app works great with the following versions:

ember --version

ember-cli: 2.13.1
node: 7.7.3
os: darwin x64

yarn list ember-awesome-macros

yarn list v0.21.3
└─ ember-awesome-macros@0.34.0
✨  Done in 1.07s.

Then I yarn upgrade ember-awesome-macros:

yarn upgrade v0.21.3
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "broccoli-tslinter@2.0.1" has unmet peer dependency "typescript@^2.0.0".
warning "broccoli-tslinter@2.0.1" has unmet peer dependency "tslint@^4.0.2".
warning "broccoli-typescript-compiler@0.6.2" has unmet peer dependency "typescript@^1.6.2 || ^1.7.0 || ^1.8.0 || ^1.9.0-dev || ^2.0.0 || ^2.0.0-dev || ^2.1.0-dev || next".
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 2 new dependencies.
├─ ember-awesome-macros@0.35.1
└─ ember-macro-helpers@0.14.0
✨  Done in 7.90s.

and I get the following error:
Error: Assertion Failed: You attempted to define a {{link-to "signup"}} but did not pass the parameters required for generating its dynamic segments. _buildComputed.buildCurriedComputed is not a function@ 266 ms

And in my signup controller, I have indeed:
import notEqual from 'ember-awesome-macros/not-equal';

Hope this helps

crhayes commented

@kellyselden I am using raw and writable the way you describe. It's weird because it was working before without me explicitly adding ember-macro-helpers as a dependency.

Here is the error:

image

kellyselden commented

I wasn't seeing your stack trace, but I did see an issue with notEqual. Fixed in #328. Could you try out v0.35.2 and see if that helps?

bartocc commented

@kellyselden I've just tried v0.35.3 (packaged with yarn 0.23.4), with no luck.

I also tried import {notEqual} from 'ember-awesome-macros'; instead of import notEqual from 'ember-awesome-macros/not-equal';, but it still fails

kellyselden commented

I cannot recreate this with a brand new project. Is you version of ember-macro-helpers old? Can you run npm ls ember-macro-helpers?

crhayes commented

@kellyselden Regarding the issue with notEqual, I didn't experience it. However, I used Ember Twiddle to confirm there was an issue using 0.35.1. It appears to be fine after testing with 0.35.2.

bartocc commented
bartocc commented

Ok, to reproduce the bug with notEqual, simply add ember-moment 7.3.0 to your project.

On my project, yarn list ember-macro-helpers outputs

yarn list v0.23.4
├─ ember-macro-helpers@0.14.1
└─ ember-moment@7.3.0
   └─ ember-macro-helpers@0.4.0
✨  Done in 0.93s.

I've created adopted-ember-addons/ember-moment#237 to ask for a new release because the version of ember-macro-helpers has been updated in the latest ember-moment commits by @kellyselden

snewcomer commented

Upgrading ember-moment/ember-computed-decorators and ember-awesome-macros fixed the problem for me. I believe this could be closed? Anybody else having problems?

kellyselden commented

Closing as I believe the original issue is resolved.