kennethreitz/pytheory

Some scales as ionian not working as expected

txemi opened this issue · 0 comments

txemi commented

Sorry if it is not an issue and my lack of musical knoledge instead, but this code did not show what I expected:

`
from pytheory import TonedScale

tsC4 = TonedScale(tonic='C4')
c4_major = tsC4['major']
c4_ionian = tsC4['ionian']
print('major: ' + str(c4_major))
print('ionian: ' + str(c4_ionian))
`

from: https://github.com/txemi/txpymusiclib/blob/master/learn_libs/learn_pytheory/t20_scale_error_report.py

and prints:

major: <Scale I=C4 II=D4 III=E4 IV=F4 V=G4 VI=A5 VII=B5 VIII=C5> ionian: <Scale I=C4 II=C#4 III=D#4 IV=F4 V=F#4 VI=G#4 VII=A#5 VIII=C5>

I expected to find for ionian same notes without decorators as said in:

https://en.wikipedia.org/wiki/Ionian_mode

I found this in muy project trying to merge scales from mingus, musthe and pytherory and watching that pytheory was the one with different output:

https://github.com/txemi/txpymusiclib/blob/master/learn_scales/scales.py