Jobs don't collapse/expand when clicking on the job title text
Closed this issue · 7 comments
Jobs don't collapse/expand when clicking on the job title text. This seems to be because in that case, the dom2mx picks up an element that doesn't have any callbacks registered. In this example, the element with id=3340 is picked up:
However, the element with id=3332 has the correct callback set.
dom2mx seems to choose the lowest ancestor of the clicked element that has an id attribute set. Indeed, when I manually remove the id=3340 attribute from that div in Chrome's inspector, then the item expands/collapses correctly when I click on the text.
Thanks, I had observed this but was not sure it was worth fixing since one can click around and eventually find something that works. But it is an easy fix (bubble the event) so I'll sort it out. Thx.
Uh-oh, I had bubbling commented out. Hopefully I did that while thrashing and forgot to re-enable.
Nice detective work, btw.
Please try it now. I think I have the immediate issue addressed, but the bubbling has introduced a new one: if we click on an tag provided by the story, the browser both navigates to the link and gives the app an onclick event, which now percolates up and gets treated as "toggle details". Working on that now.
OK, that is one hell of an edge case once we allow for the edge-edge case in which the developer wants to supply additional handling on clicks, but I think it is fine and it is live now if you want to check it out.
Sorry for the late reply!
Nice detective work, btw.
Thanks :D
Seems to work fine! Thanks for making this :)
thank you Kenny!