Comment signing quirk

Question

Comment signing quirk

felixp7 opened this issue 7 years ago · 13 comments

This is an odd one. I wasn't able to find an error message in the logs, and worse, the behavior differs between my dev and production server. But for what it's worth...

When trying to submit a comment, if the username I fill in ends in an exclamation mark (a.k.a. bang), OddMuse either seems to crash (?!) and never registers the comment, or -- on another server -- ignores the given username and records the comment as anonymous. There seem to be no lasting side effects in either case.

That pesky punctuation is not important, of course, but it did give me a fright at first.

Answer 1 · 2017-09-21T18:16:12.000Z

Oh wow, I just tried it on oddmuse.org and indeed it left a comment as anonymous. That's a wonderful find.

Answer 2 · 2017-09-22T00:56:22.000Z

Interesting! Probably because it's an illegal page name. We really ought to allow exclamation marks.

Answer 3 · 2017-11-02T13:07:12.000Z

Implemented in 51b2430. Let me know if it works.

Answer 4 · 2017-11-02T14:58:50.000Z

That's odd... in my local test environment, this new version doesn't even show the comment form. Admittedly said environment is a bit weird, but 2.3.8 works there.

Answer 5 · 2017-11-02T15:44:51.000Z

You probably need to set $CommentsPrefix.

Answer 6 · 2017-11-02T16:15:10.000Z

It's set. I used the existing setup, and just dropped the new wiki.pl in. Then dropped the old one back to make sure.

Answer 7 · 2017-11-02T20:42:26.000Z

I am at a loss. When I tried it, I had a link to Comments_on_HomePage from HomePage.

Answer 8 · 2017-11-03T07:32:54.000Z

How are we going to proceed now? It would seem to me that we can close this issue except for the missing "user acceptance test". :)

Answer 9 · 2017-11-03T07:38:46.000Z

Oh, the link is there, the comment page is there, but the comment form doesn't show up.

I'd say set this fix aside for now, as it wasn't all that important. Maybe you can try again some other time.

Answer 10 · 2017-11-03T09:07:55.000Z

Actually, I think I found a problem related to issue #12. Hopefully da06278 fixes this, and that should restore the comment form, too. The give-away was that the comment page is there but it has no title: the name of the comment page is actually undefined. The commit I mentioned should fix that.

Answer 11 · 2017-11-03T13:01:07.000Z

The comment form now shows up and seems to work fine. But now I see the "Homepage URL" field doesn't seem to undergo any validation. Simply changing the input type to "url" would at least prevent honest mistakes.

Answer 12 · 2017-11-03T16:36:02.000Z

I'm not sure we can do this since Oddmuse still emits XHTML 1.0. Somebody would have to try and report back?

Answer 13 · 2017-11-03T17:28:15.000Z

Eh, just one more detail to take care of when you change the output to html5. Thanks for everything!