kensho-technologies/graphql-compiler

Running the linting script with --diff raises additional linting errors

Opened this issue · 0 comments

During linting we run the pydocstyle command twice with different configurations: once for the testing files and once for the non-testing files. When we are linting all of the files in the repo, we pass wildcard characters and the identification of files as test and non-test files happens internally within pydocstyle through the pattern matching we specify in the .pydocstyle configuration files. When we are only linting the files with changes, we pass in a list of filenames. By passing in a list of file names, we tell pydocstyle: "forget the match patterns we specified in the configuration files and lint all of the files we provided as input". So both pydocstyle commands lint all of the input files when we run scripts/lint.sh ---diff. This is why we see additional linting errors.